Skip to content

Adds devcontainer config #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Adds devcontainer config #82

merged 2 commits into from
Dec 19, 2024

Conversation

t089
Copy link
Contributor

@t089 t089 commented Dec 15, 2024

Adds default devcontainer configuration from SSWG: https://github.com/swift-server/swift-devcontainer-template

Motivation:

Developing for linux can be challenging on macOS because some APIs are not available on Linux. By using VSCode and devcontainer you can essentially develop "on linux".

Modifications:

Adds devcontainer config.

Result:

When working in VSCode, you can now easily open the project inside a devcontainer.

Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto sebsto added the semver/none No version bump required. label Dec 19, 2024
@sebsto sebsto merged commit d2761dc into swift-server:main Dec 19, 2024
14 of 15 checks passed
@sebsto
Copy link
Contributor

sebsto commented Dec 19, 2024

Thank you @t089 for this change.
Can you port this change to the Lambda runtime project as well ? (I think .devcontainer is in the .gitignore file)
https://github.com/swift-server/swift-aws-lambda-runtime

Thanks

@t089 t089 deleted the devcontainer branch December 19, 2024 11:27
@t089
Copy link
Contributor Author

t089 commented Dec 19, 2024

Thinking about it, maybe it is better to leave this ignored and leave it to users to either set it up or not...

Especially, when you want to customize your local configuration, it becomes quite annoying.

@sebsto
Copy link
Contributor

sebsto commented Dec 19, 2024

#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants